0000832: If user timezone is empty, timezone is set incorrectly when user is edited by an admin

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000832

glFusion CMS

Administration

public

2012-01-11 10:41

2012-03-28 11:06

Reporter

lgarner

Assigned To

mark

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

1.2.2

Target Version

1.3.0

Fixed in Version

1.3.0

Summary

0000832: If user timezone is empty, timezone is set incorrectly when user is edited by an admin

Description

If the tzid field in gl_userprefs is empty, which is normal when a new user registers in 1.2.2 and prior, the site timezone isn't selected when an admin edits the user account. If the admin isn't watching for this, the timezone gets set incorrectly when the account is saved.

Steps To Reproduce

User registers (timezone is empty)
Admin edits account, doesn't look at the timezone.
Admin saves the account, timezone is set to the first entry in the selection: "-11, WST (Pacific/Apia)", or "Africa/Abidjan" for glFusion 1.3.0svn, haven't checked 1.3.0

Additional Information

The empty timezone upon registration is fixed in 1.4.0svn, but for existing accounts and as a safety measure it'd be good to check this in admin/user.php:

Index: public_html/admin/user.php
===================================================================
--- public_html/admin/user.php (revision 7048)
+++ public_html/admin/user.php (working copy)
@@ -814,7 +814,7 @@

     // Timezone

- if ( isset($U['tzid']) ) {
+ if ( isset($U['tzid']) && !empty($U['tzid']) ) {
         $timezone = $U['tzid'];
     } else {
         $timezone = $_CONF['timezone'];

Tags

No tags attached.

Attached Files

Relationships

Notes
(0001159) mark (administrator) 2012-03-28 11:06	The new timezone handling should solve this issue.

(0001160) mark (administrator) 2012-03-28 11:06	New timezone handling should resolve this issue.

Issue History
Date Modified	Username	Field	Change
2012-01-11 10:41	lgarner	New Issue
2012-03-28 11:06	mark	Assigned To	=> mark
2012-03-28 11:06	mark	Status	new => acknowledged
2012-03-28 11:06	mark	Resolution	open => fixed
2012-03-28 11:06	mark	Fixed in Version	=> 1.3.0
2012-03-28 11:06	mark	Note Added: 0001159
2012-03-28 11:06	mark	Note Added: 0001160
2012-03-28 11:06	mark	Status	acknowledged => resolved